STEP-12 Comments for Admin Users

​STEP-12​
During The testing we figured out that in react-share 4.4.0 facebook counter is not working, also Facebook messenger is not working correctly on mobile phones, and there is no actual need for share buttons on the homepage, let’s populate backend configuration comments. Which will say that to users.
 1. Here is our updated social_share.xml
 line 25 - 29
 line 25 - 29
line 49 - 53
ScandiPWA/SocialShareGraphQl/etc/adminhtml/system/social_share.xml line 25 - 29
1
<field id="home_page" translate="label" type="select" sortOrder="4" showInDefault="1" showInWebsite="0" showInStore="0">
2
   <label>Display On HomePage</label>
3
   <comment>Not Supported.</comment>
4
   <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
5
</field>
Copied!
ScandiPWA/SocialShareGraphQl/etc/adminhtml/system/social_share.xml line 55 - 67
1
<field id="enable_counter" translate="label" type="select" sortOrder="2" showInDefault="1" showInWebsite="0" showInStore="0">
2
   <label>Enable Facebook Counter</label>
3
   <comment>https://www.npmjs.com/package/react-share 4.4.0 Bugged, waiting for update</comment>
4
   <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
5
</field>
Copied!
ScandiPWA/SocialShareGraphQl/etc/adminhtml/system/social_share.xml line 49 - 53
1
<!--        Facebook Messenger-->
2
<group id="facebook_messenger" translate="label" type="text" sortOrder="1" showInDefault="1" showInWebsite="0" showInStore="0">
3
   <label>Facebook Messenger</label>
4
   <comment>Not Working on mobile devices waiting for Update https://github.com/nygardk/react-share/pull/357</comment>
5
   <field id="enable" translate="label" type="select" sortOrder="1" showInDefault="1" showInWebsite="0" showInStore="0">
6
       <label>Enable Facebook Messenger</label>
7
       <source_model>Magento\Config\Model\Config\Source\Yesno</source_model>
8
   </field>
9
​
10
   <field id="app_id" translate="text" type="text" sortOrder="2" showInDefault="1" showInWebsite="0" showInStore="0">
11
       <label>Facebook Messenger App ID</label>
12
   </field>
13
</group>
Copied!
​
​

TASK-1 Changing LinkedIn to Twitter

STEP-13 Final, bugfixes

Last modified 1yr ago

Copy link